-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!!! FEATURE: Upgrade CKEditor 5 from version 16.0.0 to 44.0.0 #3883
Conversation
The icons were broken and the fallback title was not aligned pretty well. So the SVG markup string will be transformed now to an data-uri and this can be used as image sorce.
The new type around buttons are not used by the neos ui at the moment and maybe we just dont need them. As the rendered SVGs without styled break the UI, we hide the buttons at the moment.
9804d83
to
99ce89b
Compare
Will try to check the tests tomorrow. A hint can be maybe that issue DevExpress/testcafe#7642 |
This is a workaround for the fact that the contenteditable element is not directly selectable for more information see https://testcafe.io/documentation/402688/reference/test-api/testcontroller/selecteditablecontent
98e27e7
to
ebc122b
Compare
Although I added some workarounds I still have some failing tests in the Syncing Test suites. Hope that they the community finds a solution for the contentEditable issue in testcafe. |
4211e5c
to
22183a7
Compare
And i think we should put special focus on these things when testing:
|
a101230
to
cd73131
Compare
As the firefox could not deal with the testcafe workaround. We now write the content to the CKE
57ab23a
to
0aed581
Compare
6e86c3d
to
8034d9d
Compare
8034d9d
to
a1acdf5
Compare
For auto-paragraphs we have a test ;) But I am open for feedback :) |
Found a bug with the table toolbar. When you edit a table and go to another page, the toolbar is empty except the table dropdowns. But the bugs seem familiar to me, so will check if it is just an old one. |
564c269
to
e6322a6
Compare
d0c9241
to
e6322a6
Compare
🙈 Found the matching issue for that #3512 |
THANK you so much for your effort!
now its already less big and without branding - i assume because of the licence key thingy? but still after clicking randomly on document nodes below the the code looks like
so i think we need to disable some kind of drag and drop plugin and also this aria-live thing? https://ckeditor.com/docs/ckeditor5/latest/api/module_ui_arialiveannouncer-AriaLiveAnnouncer.html (tested on firefox and safari) |
Thanks, @mhsdesign ... I will take a look. Maybe my screen is too small. Used just the MacBook for the week. |
Sometimes we need to overwrite global ck editor styles. We can put them here.
We (Neos 9 weekly meeting) decided to merge this, and if we have issues and/or future adjustments that are needed to be done as a follow-up. |
Thank you all for your efforts and work. Awesome! ❤️ |
This update represents a major leap forward, spanning several years of development. Due to the extensive changes and numerous breaking changes, it’s challenging to provide a comprehensive list of all API alterations. As such, this PR introduces a breaking change.
The CKEditor API has evolved significantly, and any plugins relying on outdated APIs may no longer function as expected. We cannot provide a detailed upgrade guide for your custom or third-party plugins. Instead, we recommend consulting the release notes of CKEditor 5 for the relevant versions. Note that during testing, some packages dependent on the old implementation were found incompatible.
To support the community, we aim to review a few community plugins and, where feasible, submit PRs to update them, offering practical examples.
This upgrade effort has been attempted multiple times over the years, but often proved too challenging to complete. We want to acknowledge and thank those who contributed to earlier PRs addressing this task, including @JamesAlias, @73nici, @skurfuerst , @mhsdesign , and @markusguenther
Testing Notes:
Acceptance tests for editable content elements encountered issues with the new CKEditor. The workaround implemented in this PR leverages TestCafe’s proposed solution, but it only works reliably in Chrome. Fortunately, the TestCafe team has already merged a PR that will likely resolve this issue in the future.
Special thanks to everyone involved in this significant effort!
Please see https://discuss.neos.io/t/feedback-needed-in-which-release-to-include-ckeditor-5-update/6707 for context and discussion.
Resolves: #2836